Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent reuse mutated route option for head #4273

Merged
merged 3 commits into from Sep 14, 2022
Merged

fix: prevent reuse mutated route option for head #4273

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4bfd17
fix: prevent reuse mutated route option for head
climba03003 Sep 14, 2022
ed22d95
test: ensure no regression
climba03003 Sep 14, 2022
43c8478
fix: typo
climba03003 Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/route.js
View file
Open in desktop
Expand Up @@ -155,6 +155,12 @@ function buildRouting (options) {
// Since we are mutating/assigning only top level props, it is fine to have a shallow copy using the spread operator
const opts = { ...options }

const { exposeHeadRoute } = opts
const hasRouteExposeHeadRouteFlag = exposeHeadRoute != null
const shouldExposeHead = hasRouteExposeHeadRouteFlag ? exposeHeadRoute : globalExposeHeadRoutes
// we need to clone a set of initial options for HEAD route
const headOpts = shouldExposeHead && options.method === 'GET' ? { ...options } : null

throwIfAlreadyStarted('Cannot add route when fastify instance is already started!')

const path = opts.url || opts.path || ''
Expand Down Expand Up @@ -342,13 +348,10 @@ function buildRouting (options) {

// register head route in sync
// we must place it after the `this.after`
const { exposeHeadRoute } = opts
const hasRouteExposeHeadRouteFlag = exposeHeadRoute != null
const shouldExposeHead = hasRouteExposeHeadRouteFlag ? exposeHeadRoute : globalExposeHeadRoutes

if (shouldExposeHead && options.method === 'GET' && !hasHEADHandler) {
const onSendHandlers = parseHeadOnSendHandlers(opts.onSend)
prepareRoute.call(this, { method: 'HEAD', url: path, options: { ...opts, onSend: onSendHandlers }, isFastify: true })
const onSendHandlers = parseHeadOnSendHandlers(headOpts.onSend)
prepareRoute.call(this, { method: 'HEAD', url: path, options: { ...headOpts, onSend: onSendHandlers }, isFastify: true })
} else if (hasHEADHandler && exposeHeadRoute) {
warning.emit('FSTDEP007')
}
Expand Down