Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent reuse mutated route option for head #4273

Merged
merged 3 commits into from Sep 14, 2022
Merged

fix: prevent reuse mutated route option for head #4273

merged 3 commits into from Sep 14, 2022

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Sep 14, 2022 •
edited

Fixes: #4271

Checklist

mcollina
mcollina requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

Uzlopak
Uzlopak reviewed Sep 14, 2022
View reviewed changes
test/route.test.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 14, 2022

@mcollina
If we can get this merged and released I can close in fastify-rate-limit fastify/fastify-rate-limit#267

maybe not a strong argument to make another release but i like when PRs are closed :D

Uzlopak
Uzlopak approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it because it is fixing the issue i have in fastify-rate-limit

mcollina
mcollina approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 21f209f into main Sep 14, 2022
@mcollina mcollina deleted the fix-reuse-route-option branch September 14, 2022 15:41
@climba03003 climba03003 mentioned this pull request Nov 16, 2022
Open
2 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exposeHeadRoute and manually generated head routes not really distingiushable
3 participants
@climba03003 @Uzlopak @mcollina