-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing types workflow #3668
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Missing Types | ||
|
||
on: | ||
pull_request: | ||
types: [labeled] | ||
|
||
jobs: | ||
create_issue: | ||
runs-on: ubuntu-latest | ||
if: contains(github.event.pull_request.labels.*.name, 'missing-types') | ||
steps: | ||
- name: Create an issue | ||
uses: octokit/request-action@v2.x | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can this just be a major version? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, didn't got your question. Do you mean if it can use another version of the action? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apologies, poor question there! Can it be a major tag i.e. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotcha. I'll check and in case replace it in next commit. EDIT: No, It can't be used with just the major. |
||
with: | ||
route: POST /repos/{owner}/{repo}/issues | ||
owner: ${{ github.repository_owner }} | ||
repo: ${{ github.event.repository.name }} | ||
title: add missing types to [${{ github.event.pull_request.title }}] | ||
body: | | ||
PR [${{ github.event.pull_request.number }}](${{ github.event.pull_request.url }}) has introduced a new feature that requires updating Fastify's typings and tests. | ||
|
||
|
||
Learn how to [contribute](https://github.com/fastify/fastify/blob/main/CONTRIBUTING.md) | ||
|
||
Get inspired by [this example PR](https://github.com/fastify/fastify/pull/3231) | ||
labels: | | ||
["good-first-issue", "typescript"] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it should be triggered only when a PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, make sense :)
I just followed the issue description. @Eomm do you agree on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does
we will avoid to open an issue for those PRs that are not merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR updated to handle this.