add missing types workflow #3668
Conversation
.github/workflows/missing_types.yml
Outdated
|
|
||
| on: | ||
| pull_request: | ||
| types: [labeled] |
There was a problem hiding this comment.
I think that it should be triggered only when a PR is merged.
There was a problem hiding this comment.
Yes, make sense :)
I just followed the issue description. @Eomm do you agree on this?
There was a problem hiding this comment.
Yes it does
- we add the lebel
- we merge the PR
- the issue is created
we will avoid to open an issue for those PRs that are not merged
There was a problem hiding this comment.
PR updated to handle this.
| if: contains(github.event.pull_request.labels.*.name, 'missing-types') | ||
| steps: | ||
| - name: Create an issue | ||
| uses: octokit/request-action@v2.x |
There was a problem hiding this comment.
Can this just be a major version?
There was a problem hiding this comment.
Sorry, didn't got your question. Do you mean if it can use another version of the action?
There was a problem hiding this comment.
Apologies, poor question there! Can it be a major tag i.e. octokit/request-action@v2 as opposed to using both a major and minor tag (v2.x)?
There was a problem hiding this comment.
Gotcha.
I'll check and in case replace it in next commit.
EDIT: No, It can't be used with just the major.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run testandnpm run benchmarkand the Code of conduct
As per the issue #3664 I've introduced a new workflows that automatically create an issue for missing typescript for specific labeled PR.
@Eomm I did not got your last comment, about the title, please, review the workflow and let me know if something is not like you expect.