Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update glob to version 8 and fix broken tests #297

Merged
merged 2 commits into from
May 11, 2022
Merged

fix: update glob to version 8 and fix broken tests #297

merged 2 commits into from
May 11, 2022

Commits on May 10, 2022

  1. fix: update glob to version 8 and fix broken tests 

    In this release glob stopped accepting backward slashes on it's patterns, since `path.join` wil lreturn backward slashes on windows it they have to be replaced by a forward slash which is the posix separator.

I'm not entirely sure about all the consequences of this
change but all the tests seem to be passing and everything should work normally AFAIK since windows accept both backward and forward slashes as path separator.

Closes fastify#281 since glob is already being updated here.
    @guilhermelimak
    guilhermelimak committed May 10, 2022
    Configuration menu
    Copy the full SHA
    565c2ef View commit details
    Browse the repository at this point in the history

  2. fix: change replaceAll to regex to support node@14

    @guilhermelimak
    guilhermelimak committed May 10, 2022
    Configuration menu
    Copy the full SHA
    6cc7bd8 View commit details
    Browse the repository at this point in the history