fix: update glob to version 8 and fix broken tests #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this release glob stopped accepting backward slashes on it's patterns, since `path.join` wil lreturn backward slashes on windows it they have to be replaced by a forward slash which is the posix separator. I'm not entirely sure about all the consequences of this change but all the tests seem to be passing and everything should work normally AFAIK since windows accept both backward and forward slashes as path separator. Closes fastify#281 since glob is already being updated here.
climba03003
requested changes
May 10, 2022
2 tasks
|
@mcollina can we please release a new version with this fix? |
|
v6.1.0 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this release glob stopped accepting backward slashes on it's patterns, since
path.joinwill return backward slashes on windows they have to be replaced by a forward slash which is the posix separator.I'm not entirely sure about all the implications of this change, specially regarding performance but all the tests seem to be passing and everything should work normally AFAIK since windows accept both backward and forward slashes as path separator.
Closes #281 since glob is already being updated here.
Checklist
npm run testandnpm run benchmarkand the Code of conduct