Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker::Address.postcode (locale=ja) should contains hyphen #2326

Merged
merged 4 commits into from May 30, 2021
Merged

Faker::Address.postcode (locale=ja) should contains hyphen #2326

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5109844
:bug: Fix indentation ( `ja.faker.name` to `ja.faker.color.name` )
gongo May 18, 2021
a4ac658
:art: Convert a huge one-line array to multiple lines
gongo May 18, 2021
cdd4a27
:bug: Japanese postcode has a hyphen.
gongo May 18, 2021
b233453
Update test/test_ja_locale.rb
gongo May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
124,435 changes: 124,434 additions & 1 deletion lib/locales/ja/address.yml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/locales/ja/color.yml
View file
Open in desktop
@@ -1,4 +1,4 @@
ja:
faker:
color:
name: ["赤", "緑", "青", "黄", "紫", "ミントグリーン", "ティール", "白", "黒", "オレンジ", "ピンク", "灰色", "栗色", "バイオレット", "ターコイズブルー", "タン", "空色", "サーモン", "プラム", "オーキッド", "オリーブ", "マゼンタ", "ライム", "アイボリー", "藍色", "金", "フクシア", "シアン", "紺碧", "ラベンダー", "銀"]
name: ["赤", "緑", "青", "黄", "紫", "ミントグリーン", "ティール", "白", "黒", "オレンジ", "ピンク", "灰色", "栗色", "バイオレット", "ターコイズブルー", "タン", "空色", "サーモン", "プラム", "オーキッド", "オリーブ", "マゼンタ", "ライム", "アイボリー", "藍色", "金", "フクシア", "シアン", "紺碧", "ラベンダー", "銀"]
2 changes: 1 addition & 1 deletion test/test_ja_locale.rb
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ def teardown
def test_ja_address_methods
assert Faker::Address.postcode.is_a? String
# Added Actual Japanese Zipcodes in lib/locals/ja.yml
assert_equal Faker::Address.postcode.size, 7
assert_match(/^\d{3}-\d{4}$/, Faker::Address.postcode)
gongo marked this conversation as resolved.
Show resolved Hide resolved
assert_not_english(Faker::Address.postcode)
assert Faker::Address.state.is_a? String
assert_not_english(Faker::Address.state)
Expand Down