Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker::Address.postcode (locale=ja) should contains hyphen #2326

Merged
merged 4 commits into from May 30, 2021
Merged

Faker::Address.postcode (locale=ja) should contains hyphen #2326

merged 4 commits into from May 30, 2021

Commits on May 18, 2021

  1. 🐛 Fix indentation ( ja.faker.name to ja.faker.color.name ) 

    via faker-ruby#2315
    @gongo
    gongo committed May 18, 2021
    Copy the full SHA
    5109844 View commit details
    Browse the repository at this point in the history

  2. 🎨 Convert a huge one-line array to multiple lines 

    Because the file cannot be opened with a weak editor...
    @gongo
    gongo committed May 18, 2021
    Copy the full SHA
    a4ac658 View commit details
    Browse the repository at this point in the history

  3. 🐛 Japanese postcode has a hyphen. 

    via: faker-ruby#2297
    @gongo
    gongo committed May 18, 2021
    Copy the full SHA
    cdd4a27 View commit details
    Browse the repository at this point in the history

  4. Update test/test_ja_locale.rb 

    Co-authored-by: Koichi ITO <koic.ito@gmail.com>
    @gongo @koic
    gongo and koic committed May 18, 2021
    Copy the full SHA
    b233453 View commit details
    Browse the repository at this point in the history