add Japanese actual zipcodes in locals/ja.yml #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Apr 11, 2021
gongo
added a commit
to gongo/faker
that referenced
this pull request
May 18, 2021
vbrazo
pushed a commit
that referenced
this pull request
May 30, 2021
* 🐛 Fix indentation ( `ja.faker.name` to `ja.faker.color.name` ) via #2315 * 🎨 Convert a huge one-line array to multiple lines Because the file cannot be opened with a weak editor... * 🐛 Japanese postcode has a hyphen. via: #2297 * Update test/test_ja_locale.rb Co-authored-by: Koichi ITO <koic.ito@gmail.com> Co-authored-by: Koichi ITO <koic.ito@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Japanese actual zipcodes data in locales/ja.yml
Resource:
Japan Post Download Site
Example