Skip to content

Commit

Permalink
Faker::Address.postcode (locale=ja) should contains hyphen (#2326)
Browse files Browse the repository at this point in the history
* 🐛 Fix indentation ( `ja.faker.name` to `ja.faker.color.name` )

via #2315

* 🎨 Convert a huge one-line array to multiple lines

Because the file cannot be opened with a weak editor...

* 🐛 Japanese postcode has a hyphen.

via: #2297

* Update test/test_ja_locale.rb

Co-authored-by: Koichi ITO <koic.ito@gmail.com>

Co-authored-by: Koichi ITO <koic.ito@gmail.com>
  • Loading branch information
gongo and koic committed May 30, 2021
1 parent 3f0ddf9 commit e1bd4a5
Show file tree
Hide file tree
Showing 2 changed files with 124,435 additions and 2 deletions.
124,435 changes: 124,434 additions & 1 deletion lib/locales/ja/address.yml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test_ja_locale.rb
Expand Up @@ -14,7 +14,7 @@ def teardown
def test_ja_address_methods
assert Faker::Address.postcode.is_a? String
# Added Actual Japanese Zipcodes in lib/locals/ja.yml
assert_equal Faker::Address.postcode.size, 7
assert_match(/\A\d{3}-\d{4}\z/, Faker::Address.postcode)
assert_not_english(Faker::Address.postcode)
assert Faker::Address.state.is_a? String
assert_not_english(Faker::Address.state)
Expand Down

0 comments on commit e1bd4a5

Please sign in to comment.