Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update brazilian phone country code #2285

Merged
merged 5 commits into from Mar 30, 2021
Merged

Fix update brazilian phone country code #2285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9fac06
Fix Update brazilian phone country code
Mar 22, 2021
c6efa41
Add test to brazilian phone number country code
Mar 30, 2021
51db3c5
Fix Rubocop Warnings
Mar 30, 2021
dc29c41
Fix Rubocop warning
Mar 30, 2021
605c4db
Fix Syntax
Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/locales/pt-BR.yml
View file
Open in desktop
Expand Up @@ -653,6 +653,7 @@ pt-BR:
- "#{Team.main_teams}"
sport: ['handebol', 'basquete', 'futebol', 'UFC', 'volêi', 'tênis']

country_code: ['55']
Copy link
Member

@vbrazo vbrazo Mar 22, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should have a test that checks if this locale is correct. Could you please add that?

Reference: https://github.com/faker-ruby/faker/blob/master/test/test_pt_br_locale.rb#L20

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbrazo Done!

I am edit the files directly from GH, that's why so many commits. rs

phone_number:
subscriber_number: ['####']
area_code: ["11", "12", "13", "14", "15", "16", "17", "18", "19", "21", "22", "24", "27", "28", "31", "32", "33", "34", "35", "37", "38", "41", "42", "43", "44", "45", "46", "47", "48", "49", "51", "53", "54", "55", "61", "62", "63", "64", "65", "66", "67", "68", "69", "71", "73", "74", "75", "77", "79", "81", "82", "83", "84", "85", "86", "87", "88", "89", "91", "92", "93", "94", "95", "96", "97", "98", "99"]
Expand Down
4 changes: 4 additions & 0 deletions test/test_pt_br_locale.rb
View file
Open in desktop
Expand Up @@ -36,6 +36,10 @@ def test_pt_br_address_methods
assert Faker::Address.default_country, 'Brasil'
end

def test_pt_br_phone_methods
assert_equal Faker::PhoneNumber.country_code, '+55'
end

def test_pt_br_color_methods
assert Faker::Color.hex_color.is_a? String
assert Faker::Color.hex_color.match(/^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})$/)
Expand Down