Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update brazilian phone country code #2285

Merged
merged 5 commits into from Mar 30, 2021

Conversation

ricardopacheco
Copy link

This fix method cell_phone_in_e164 for brazil.

This fix method cell_phone_in_e164 for brazil.
@@ -653,6 +653,7 @@ pt-BR:
- "#{Team.main_teams}"
sport: ['handebol', 'basquete', 'futebol', 'UFC', 'volêi', 'tênis']

country_code: ['55']
Copy link
Member

@vbrazo vbrazo Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should have a test that checks if this locale is correct. Could you please add that?

Reference: https://github.com/faker-ruby/faker/blob/master/test/test_pt_br_locale.rb#L20

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbrazo Done!

I am edit the files directly from GH, that's why so many commits. rs

@ricardopacheco ricardopacheco changed the title Fix Update brazilian phone country code Fix update brazilian phone country code Mar 22, 2021
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vbrazo vbrazo merged commit 08cd44c into faker-ruby:master Mar 30, 2021
@ricardopacheco ricardopacheco deleted the patch-1 branch July 30, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants