Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YARD docs for Doctor Who and fix a method name. #1758

Merged
merged 6 commits into from Sep 21, 2019
Merged

Add YARD docs for Doctor Who and fix a method name. #1758

merged 6 commits into from Sep 21, 2019

Commits on Sep 21, 2019

  1. Add YARD docs for Doctor Who. 

    This also adds an alias of 'villain' for 'villian', since it's spelled
wrong, and marks 'villian' as being deprecated.
    @connorshea
    connorshea committed Sep 21, 2019
    Copy the full SHA
    1d52ede View commit details
    Browse the repository at this point in the history

  2. Fix 'villians' typo in dr_who.yml.

    @connorshea
    connorshea committed Sep 21, 2019
    Copy the full SHA
    265a0f6 View commit details
    Browse the repository at this point in the history

  3. Fix Rubocop warning for Doctor Who faker.

    @connorshea
    connorshea committed Sep 21, 2019
    Copy the full SHA
    2424e57 View commit details
    Browse the repository at this point in the history

  4. Fix syntax error in dr_who.rb.

    @connorshea
    connorshea committed Sep 21, 2019
    Copy the full SHA
    dcaf07a View commit details
    Browse the repository at this point in the history

  5. Bad rubocop, no donut.

    @connorshea
    connorshea committed Sep 21, 2019
    Copy the full SHA
    e717ba9 View commit details
    Browse the repository at this point in the history

  6. Change 'villian' to be defined as an alias. 

    Also add a test for the villain method.
    @connorshea
    connorshea committed Sep 21, 2019
    Copy the full SHA
    821d326 View commit details
    Browse the repository at this point in the history