Add YARD docs for Doctor Who and fix a method name. #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds an alias of 'villain' for 'villian', since it's spelled wrong, and marks 'villian' as being deprecated.
Zeragamba
requested changes
Sep 21, 2019
Also add a test for the villain method.
Closed
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
…-add-docs Add YARD docs for Doctor Who and fix a method name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds YARD docs for the Doctor Who faker, and also adds an alias of 'villain' for 'villian', since it's spelled wrong. I've marked 'villian' as being deprecated and replaced it in the Markdown examples.
EDIT: Also changed the YML key, I assume we consider those 'private' so we can change them as we like?