Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Symbol to String conversion in ReactPropTypes.oneOf #9202

Closed
wants to merge 2 commits into from
Closed

Fix Symbol to String conversion in ReactPropTypes.oneOf #9202

wants to merge 2 commits into from

Commits on Mar 17, 2017

  1. Fix Symbol to String conversion in ReactPropTypes.oneOf 

    The safe way to convert a `Symbol` into a `String` is to use `String(sym)` or
`sym.toString()`. Using template string interpolation (ES6) or concatenation (ES5/Babel)
throws a `TypeError`.

Closes #9181
    @ooflorent
    ooflorent committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    66caa76 View commit details
    Browse the repository at this point in the history

  2. Display symbols when used in ReactPropTypes.oneOf

    @ooflorent
    ooflorent committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    15d45b5 View commit details
    Browse the repository at this point in the history