Fix Symbol to String conversion in ReactPropTypes.oneOf #9202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The safe way to convert a `Symbol` into a `String` is to use `String(sym)` or `sym.toString()`. Using template string interpolation (ES6) or concatenation (ES5/Babel) throws a `TypeError`. Closes #9181
|
PropTypes have been removed from React core and now exist as a separate package Sorry about that @ooflorent! |
|
@ooflorent I've opened a new issue for this at facebook/prop-types#10 if you want to continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues when using symbols in
PropTypes.oneOf(#9181).The safe way to convert a
Symbolinto aStringis to useString(sym)orsym.toString(). Using template string interpolation (ES6) or concatenation (ES5/Babel) throws aTypeError.The current warning does not include symbols (because
JSON.stringifystrips them). A replacer is added to handle them. This is done in the second commit (so it can be easily reverted).