Convert ReactDOMEventPropagation to createRoot #28177

eps1lon · 2024-01-31T22:56:48Z

No description provided.

react-sizebot · 2024-01-31T23:00:29Z

Comparing: d29f7d9...6215432

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against 6215432

rickhanlonii · 2024-02-01T23:47:42Z

packages/react-dom/src/__tests__/ReactDOMEventPropagation-test.js

    if (container) {
-      OuterReactDOM.unmountComponentAtNode(container);
+      await act(() => {


You don't need act for unmount right?

I was under the impression Passive effects are not destroyed synchronously when unmounting as of #17925. We still have a test for that in ReactHooksWithNoopRenderer but maybe I misunderstood it?

That's why I always wrap unmount in act to make sure everything from the component is cleaned up.

DiffTrain build for commit f5a3158.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 31, 2024

eps1lon marked this pull request as ready for review January 31, 2024 23:04

Convert ReactDOMEventPropagation to createRoot

6215432

eps1lon force-pushed the test/create-root/ReactDOMEventPropagation branch from af9347e to 6215432 Compare January 31, 2024 23:05

eps1lon changed the title ~~Convert ReactDOMSelection~~ Convert ReactDOMEventPropagation to createRoot Jan 31, 2024

rickhanlonii reviewed Feb 1, 2024

View reviewed changes

gaearon approved these changes Feb 3, 2024

View reviewed changes

eps1lon merged commit f5a3158 into facebook:main Feb 4, 2024
36 checks passed

eps1lon deleted the test/create-root/ReactDOMEventPropagation branch February 4, 2024 10:29

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert ReactDOMEventPropagation to createRoot (facebook#28177)

94355c1

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert ReactDOMEventPropagation to createRoot (#28177)

938ac4c

DiffTrain build for commit f5a3158.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactDOMEventPropagation to createRoot #28177

Convert ReactDOMEventPropagation to createRoot #28177

eps1lon commented Jan 31, 2024

react-sizebot commented Jan 31, 2024 •

edited

rickhanlonii Feb 1, 2024

eps1lon Feb 2, 2024

Convert ReactDOMEventPropagation to createRoot #28177

Convert ReactDOMEventPropagation to createRoot #28177

Conversation

eps1lon commented Jan 31, 2024

react-sizebot commented Jan 31, 2024 • edited

Critical size changes

Significant size changes

rickhanlonii Feb 1, 2024

Choose a reason for hiding this comment

eps1lon Feb 2, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 31, 2024 •

edited