Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React from 60a927d04 to 2bc7d336a #61522

Merged
merged 2 commits into from Feb 6, 2024
Merged

Update React from 60a927d04 to 2bc7d336a #61522

merged 2 commits into from Feb 6, 2024

Conversation

gnoff
Copy link
Contributor

@gnoff gnoff commented Feb 1, 2024 •
edited

Updates React from 60a927d04 to 2bc7d336a

Also updates aliases for react.shared-subset to react.react-server

React upstream changes

Closes NEXT-2331

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team type: next labels Feb 1, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 1, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-2bc7d336a-20240205 Transitive: environment +3 536 kB
npm/react-dom@18.3.0-canary-2bc7d336a-20240205 Transitive: environment +3 536 kB
npm/react-server-dom-turbopack@0.0.0-experimental-2bc7d336a-20240205 Transitive: environment +7 5.79 MB
npm/react-server-dom-turbopack@18.3.0-canary-2bc7d336a-20240205 Transitive: environment +7 5.79 MB
npm/react-server-dom-webpack@0.0.0-experimental-2bc7d336a-20240205 Transitive: environment, eval, filesystem, network, shell, unsafe +85 24.6 MB
npm/react-server-dom-webpack@18.3.0-canary-2bc7d336a-20240205 Transitive: environment, eval, filesystem, network, shell, unsafe +85 24.6 MB
npm/react@18.3.0-canary-2bc7d336a-20240205 Transitive: environment +1 5.81 kB
npm/scheduler@0.0.0-experimental-2bc7d336a-20240205 Transitive: environment +1 220 kB fb, gnoff, react-bot, ...1 more
npm/scheduler@0.24.0-canary-2bc7d336a-20240205 Transitive: environment +1 220 kB fb, gnoff, react-bot, ...1 more

🚮 Removed packages: npm/react-dom@0.0.0-experimental-60a927d04-20240113, npm/react-dom@18.3.0-canary-60a927d04-20240113, npm/react-server-dom-turbopack@0.0.0-experimental-60a927d04-20240113, npm/react-server-dom-turbopack@18.3.0-canary-60a927d04-20240113, npm/react-server-dom-webpack@0.0.0-experimental-60a927d04-20240113, npm/react-server-dom-webpack@18.3.0-canary-60a927d04-20240113, npm/react@0.0.0-experimental-60a927d04-20240113, npm/react@18.3.0-canary-60a927d04-20240113, npm/scheduler@0.0.0-experimental-60a927d04-20240113, npm/scheduler@0.24.0-canary-60a927d04-20240113

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 1, 2024 •
edited

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 1, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary gnoff/next.js bump-react Change
buildDuration 11.9s 11.9s N/A
buildDurationCached 6s 5.2s N/A
nodeModulesSize 200 MB 196 MB N/A
nextStartRea..uration (ms) 407ms 426ms N/A
Client Bundles (main, webpack)
vercel/next.js canary gnoff/next.js bump-react Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB N/A
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 240 B ✓
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 47.2 kB 47.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gnoff/next.js bump-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary gnoff/next.js bump-react Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 501 B N/A
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.19 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 106 B 106 B ✓
Client Build Manifests
vercel/next.js canary gnoff/next.js bump-react Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary gnoff/next.js bump-react Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 538 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary gnoff/next.js bump-react Change
edge-ssr.js gzip 94 kB 94.1 kB N/A
page.js gzip 150 kB 149 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary gnoff/next.js bump-react Change
middleware-b..fest.js gzip 622 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.7 kB 37.7 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary gnoff/next.js bump-react Change
app-page-exp...dev.js gzip 170 kB 166 kB N/A
app-page-exp..prod.js gzip 95.8 kB 95 kB N/A
app-page-tur..prod.js gzip 96.4 kB 96.8 kB ⚠️ +350 B
app-page-tur..prod.js gzip 91 kB 91.3 kB ⚠️ +326 B
app-page.run...dev.js gzip 142 kB 135 kB N/A
app-page.run..prod.js gzip 90.3 kB 89.9 kB N/A
app-route-ex...dev.js gzip 22.2 kB 22 kB N/A
app-route-ex..prod.js gzip 14.9 kB 14.8 kB N/A
app-route-tu..prod.js gzip 14.9 kB 14.8 kB N/A
app-route-tu..prod.js gzip 14.5 kB 14.6 kB N/A
app-route.ru...dev.js gzip 21.7 kB 21.7 kB N/A
app-route.ru..prod.js gzip 14.5 kB 14.6 kB N/A
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB ✓
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB ✓
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 22.7 kB 22.7 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 49.7 kB 49.7 kB ✓
Overall change 332 kB 333 kB ⚠️ +676 B
Diff details
Diff for page.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for 68-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: cc052d9

@gnoff gnoff changed the title Update React from 60a927d04 to 1219d57fc Update React from 60a927d04 to 95ec12839 Feb 5, 2024
@gnoff gnoff changed the title Update React from 60a927d04 to 95ec12839 Update React from 60a927d04 to 2bc7d336a Feb 6, 2024
@gnoff
updated React from 60a927d04 to 2bc7d336a.
6290768 
- facebook/react#28250
- facebook/react#28225
- facebook/react#28123
- facebook/react#28240
- facebook/react#28239
- facebook/react#28245
- facebook/react#28244
- facebook/react#28238
- facebook/react#28235
- facebook/react#28221
- facebook/react#28215
- facebook/react#28214
- facebook/react#28213
- facebook/react#28212
- facebook/react#28211
- facebook/react#28247
- facebook/react#28210
- facebook/react#28186
- facebook/react#28232
- facebook/react#28169
- facebook/react#28177
- facebook/react#28170
- facebook/react#28168
- facebook/react#28122
- facebook/react#27982
- facebook/react#28217
- facebook/react#28223
- facebook/react#28208
- facebook/react#28209
- facebook/react#28200
- facebook/react#28199
- facebook/react#28198
- facebook/react#28197
- facebook/react#28196
- facebook/react#28194
- facebook/react#28192
- facebook/react#28191
- facebook/react#28182
- facebook/react#28181
- facebook/react#28180
- facebook/react#28178
- facebook/react#28201
- facebook/react#28176
- facebook/react#28162
- facebook/react#28131
- facebook/react#28190
- facebook/react#28172
- facebook/react#28171
- facebook/react#28173
- facebook/react#28174
- facebook/react#28175
- facebook/react#28136
- facebook/react#28135
- facebook/react#28134
- facebook/react#28133
- facebook/react#28132
- facebook/react#28130
- facebook/react#28202
- facebook/react#28102
- facebook/react#28161
- facebook/react#28193
- facebook/react#28195
- facebook/react#28189
- facebook/react#28160
- facebook/react#28096
- facebook/react#28183
- facebook/react#28125
- facebook/react#28157
- facebook/react#28115
- facebook/react#28124
- facebook/react#28163
- facebook/react#28164
- facebook/react#28150
- facebook/react#28159
- facebook/react#28069
- facebook/react#28110
- facebook/react#28148
- facebook/react#28116
- facebook/react#28099
- facebook/react#28100
- facebook/react#28147
- facebook/react#28128
- facebook/react#28126
- facebook/react#28139
- facebook/react#28140
- facebook/react#28141
- facebook/react#28142
- facebook/react#28113
- facebook/react#28129
- facebook/react#28114
- facebook/react#28053
- facebook/react#28091
- facebook/react#28087
- facebook/react#28112
- facebook/react#28086
- facebook/react#28101
- facebook/react#28106
- facebook/react#28117
- facebook/react#28118
- facebook/react#28105
- facebook/react#27883
- facebook/react#28111
- facebook/react#28095
- facebook/react#28108
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
- facebook/react#28090
- facebook/react#28089
- facebook/react#28076
- facebook/react#28074
- facebook/react#28103
- facebook/react#28098
- facebook/react#28097
- facebook/react#28068
- facebook/react#28093
- facebook/react#28094
- facebook/react#28073
- facebook/react#28084
- facebook/react#28063
- facebook/react#28085
- facebook/react#28083
- facebook/react#28065
- facebook/react#28061
- facebook/react#28077
- facebook/react#28075
- facebook/react#28078
- facebook/react#28050
- facebook/react#28011
- facebook/react#28055
- facebook/react#28066
- facebook/react#28067
- facebook/react#28010
- facebook/react#27993
- facebook/react#28052
- facebook/react#28060
- facebook/react#28059
- facebook/react#28034
- facebook/react#28033
- facebook/react#28004
- facebook/react#28051
- facebook/react#28012
- facebook/react#28001
- facebook/react#28002
- facebook/react#27995
- facebook/react#28006
- facebook/react#28005
- facebook/react#28007
- facebook/react#28008
- facebook/react#28009
- facebook/react#28000
- facebook/react#28003
- facebook/react#27997
- facebook/react#27240
- facebook/react#27977
- facebook/react#27940
- facebook/react#27939
@gnoff
updates react.shared-subset to react.react-server
cc052d9
@gnoff gnoff merged commit 2395557 into vercel:canary Feb 6, 2024
67 checks passed
@gnoff gnoff deleted the bump-react branch February 6, 2024 02:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnoff @ijjk @huozhi