Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape bootstrapScriptContent for javascript embedding into HTML #24385

Merged
merged 5 commits into from Apr 16, 2022

Commits on Apr 15, 2022

  1. Escape bootstrapScriptContent for javascript embedding into HTML

    The previous escape was for Text into HTML and breaks script contents. The new escaping ensures that the script contents cannot prematurely close the host script tag by escaping script open and close string sequences using a unicode escape substitution.
    gnoff committed Apr 15, 2022
    Copy the full SHA
    11483ce View commit details
    Browse the repository at this point in the history
  2. de-generalize to specific use case and refactor tests

    the escaping of this function does is tailored to the specific use case of how bootstrapScriptContent is currently set up and having it be a module suggests it is meant for a more general than it has been considered for.
    
    Additionally the tests were redone to focus on practical implications for what is and is not escaped
    gnoff committed Apr 15, 2022
    Copy the full SHA
    52786bf View commit details
    Browse the repository at this point in the history
  3. fix tests in ci, whyyyyy???

    gnoff committed Apr 15, 2022
    Copy the full SHA
    d12c8f8 View commit details
    Browse the repository at this point in the history
  4. experimental please?

    gnoff committed Apr 15, 2022
    Copy the full SHA
    ac43a1b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2022

  1. Copy the full SHA
    b8e4253 View commit details
    Browse the repository at this point in the history