Escape bootstrapScriptContent for javascript embedding into HTML #24385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoff
force-pushed
the
fizz-escape-script
branch
from
11ea57a
to
be5bc4d
Compare
|
Comparing: 726ba80...b8e4253 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gnoff
commented
Apr 15, 2022
sebmarkbage
approved these changes
Apr 15, 2022
|
|
||
| const scriptRegex = /(<\/|<)(s)(cript)/gi; | ||
| const scriptReplacer = (match, prefix, s, suffix) => | ||
| `${prefix}${substitutions[s]}${suffix}`; |
There was a problem hiding this comment.
Let's make this an inline condition instead of going through a whole hidden class check and fake-map look up.
There was a problem hiding this comment.
I meant s === 's' ? '\\u0073' : '\\u0053'
packages/react-dom/src/__tests__/escapeScriptForBrowser-test.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/__tests__/escapeScriptForBrowser-test.js
Outdated
Show resolved
Hide resolved
gnoff
force-pushed
the
fizz-escape-script
branch
from
5a3e000
to
7dd5cc7
Compare
The previous escape was for Text into HTML and breaks script contents. The new escaping ensures that the script contents cannot prematurely close the host script tag by escaping script open and close string sequences using a unicode escape substitution.
gnoff
force-pushed
the
fizz-escape-script
branch
from
7dd5cc7
to
11c06bf
Compare
the escaping of this function does is tailored to the specific use case of how bootstrapScriptContent is currently set up and having it be a module suggests it is meant for a more general than it has been considered for. Additionally the tests were redone to focus on practical implications for what is and is not escaped
gnoff
force-pushed
the
fizz-escape-script
branch
from
11c06bf
to
52786bf
Compare
sebmarkbage
reviewed
Apr 16, 2022
| const scriptReplacer = (match, prefix, s, suffix) => | ||
| `${prefix}${s === 's' ? '\\u0073' : '\\u0053'}${suffix}`; | ||
|
|
||
| function escapeBootstrapScriptContent(scriptText) { |
There was a problem hiding this comment.
Maybe a leave a comment with the rationale and clarifying that this only works if the whole content is encoded and if it's an actual JS script tag, and doesn't work for attributes or CSS.
This was referenced Mar 4, 2023
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous escape was for Text into HTML and breaks script contents. The new escaping ensures that the script contents cannot prematurely close the host script tag by escaping script open and close string sequences using a unicode escape substitution.
closes: #23063