Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.13 patch #18344

Closed
wants to merge 4 commits into from
Closed

16.13 patch #18344

wants to merge 4 commits into from

Commits on Mar 19, 2020

  1. Bugfix: Dropped effects in Legacy Mode Suspense (facebook#18238) 

    * Failing: Dropped effects in Legacy Mode Suspense

* Transfer mounted effects on suspend in legacy mode

In legacy mode, a component that suspends bails out and commit in
its previous state. If the component previously had mounted effects,
we must transfer those to the work-in-progress so they don't
get dropped.
    @acdlite
    acdlite committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    82cf50a View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary warnings (facebook#18135)

    @gaearon @acdlite
    gaearon authored and acdlite committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    2186beb View commit details
    Browse the repository at this point in the history

  3. improve error message for cross-functional component updates (faceboo… 

    …k#18316)

* improve error message for cross-functional component updates

* correctly use %s by quoting it

* use workInProgress and lint

* add test assertion

* fix test

* Improve the error message

Co-authored-by: Dan Abramov <dan.abramov@me.com>
    @JoviDeCroock @gaearon @acdlite
    2 people authored and acdlite committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    7554ab7 View commit details
    Browse the repository at this point in the history

  4. Don't fire the render phase update warning for class lifecycles (face… 

    …book#18330)

* Change the warning to not say "function body"

This warning is more generic and may happen with class components too.

* Dedupe by the rendering component

* Don't warn outside of render
    @gaearon @acdlite
    gaearon authored and acdlite committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    da83408 View commit details
    Browse the repository at this point in the history