Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.13 patch #18344

Closed
wants to merge 4 commits into from
Closed

16.13 patch #18344

wants to merge 4 commits into from

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 19, 2020 •
edited

Patch release branch for 16.3.

Based on d28bd29, the commit used to build 16.13.0.

Release candidate: 0.0.0-da834083c

Test Plan

Changelog

React DOM

  • Fix bug in legacy mode Suspense where effect clean-up functions are not fired. This only affects users who use Suspense for data fetching in legacy mode, which is not technically supported. (@acdlite in #18238)
  • Revert warning for cross-component updates that happen inside class render lifecycles (componentWillReceiveProps, shouldComponentUpdate, and so on). (@gaearon in #18330)

@acdlite
Bugfix: Dropped effects in Legacy Mode Suspense (facebook#18238)
82cf50a 
* Failing: Dropped effects in Legacy Mode Suspense

* Transfer mounted effects on suspend in legacy mode

In legacy mode, a component that suspends bails out and commit in
its previous state. If the component previously had mounted effects,
we must transfer those to the work-in-progress so they don't
get dropped.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 19, 2020
gaearon and others added 3 commits March 19, 2020 11:34
@gaearon @acdlite
Remove unnecessary warnings (facebook#18135)
2186beb
@JoviDeCroock @gaearon @acdlite
improve error message for cross-functional component updates (faceboo…
7554ab7 
…k#18316)

* improve error message for cross-functional component updates

* correctly use %s by quoting it

* use workInProgress and lint

* add test assertion

* fix test

* Improve the error message

Co-authored-by: Dan Abramov <dan.abramov@me.com>
@gaearon @acdlite
Don't fire the render phase update warning for class lifecycles (face…
da83408 
…book#18330)

* Change the warning to not say "function body"

This warning is more generic and may happen with class components too.

* Dedupe by the rendering component

* Don't warn outside of render
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 19, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da83408:

Sandbox Source
eager-breeze-eey7y Configuration

@sizebot
Copy link

sizebot commented Mar 19, 2020

Details of bundled changes.

Comparing: d28bd29...da83408

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.development.js +2.2% +0.3% 26.87 KB 27.46 KB 5.5 KB 5.51 KB NODE_DEV
react-noop-renderer.production.min.js 🔺+2.5% 🔺+0.6% 10.78 KB 11.05 KB 3.28 KB 3.3 KB NODE_PROD
react-noop-renderer-server.production.min.js 0.0% -0.2% 864 B 864 B 489 B 488 B NODE_PROD
react-noop-renderer-flight-client.development.js 0.0% -0.1% 1.42 KB 1.42 KB 724 B 723 B NODE_DEV
react-noop-renderer-persistent.development.js +2.2% +0.3% 26.92 KB 27.52 KB 5.51 KB 5.53 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 🔺+2.5% 🔺+0.7% 10.8 KB 11.07 KB 3.29 KB 3.31 KB NODE_PROD
react-noop-renderer-flight-server.development.js 0.0% -0.1% 1.98 KB 1.98 KB 906 B 905 B NODE_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js 0.0% +0.1% 405.88 KB 406 KB 73.83 KB 73.89 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 136.57 KB 136.57 KB 34.98 KB 34.98 KB UMD_DEV
react-dom.development.js -0.1% 0.0% 885.6 KB 885.07 KB 195.2 KB 195.22 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.99 KB 9.99 KB 3.38 KB 3.38 KB NODE_PROD
react-dom.production.min.js 0.0% 0.0% 115.85 KB 115.9 KB 37.08 KB 37.08 KB UMD_PROD
react-dom.profiling.min.js 0.0% +0.1% 119.38 KB 119.43 KB 38.28 KB 38.31 KB UMD_PROFILING
react-dom.development.js -0.1% 0.0% 839.19 KB 838.7 KB 191.61 KB 191.63 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.93 KB 115.98 KB 36.45 KB 36.44 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.31 KB 20.31 KB 7.53 KB 7.52 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 119.61 KB 119.66 KB 37.51 KB 37.51 KB NODE_PROFILING
ReactDOM-dev.js -0.1% -0.0% 936.45 KB 935.93 KB 208.25 KB 208.25 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 🔺+0.1% 394.59 KB 394.71 KB 71.68 KB 71.74 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.93 KB 3.93 KB 1.45 KB 1.45 KB NODE_DEV
ReactDOMTesting-dev.js -0.1% 0.0% 895.79 KB 895.28 KB 199.82 KB 199.85 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 🔺+0.1% 381.65 KB 381.77 KB 69.4 KB 69.46 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% 0.0% 125.93 KB 125.93 KB 33.61 KB 33.61 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% +0.1% 381.65 KB 381.77 KB 69.4 KB 69.46 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 11.2 KB 11.2 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.19 KB 1.19 KB 699 B 698 B UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 49.51 KB 49.51 KB 13.54 KB 13.54 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.96 KB 10.96 KB 4.08 KB 4.08 KB NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against da83408

@sizebot
Copy link

sizebot commented Mar 19, 2020

Details of bundled changes.

Comparing: d28bd29...da83408

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.7 KB 123.74 KB 38.58 KB 38.58 KB NODE_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.08 KB 59.08 KB 14.75 KB 14.75 KB UMD_DEV
ReactDOM-dev.js -0.0% 0.0% 894.37 KB 893.95 KB 199.62 KB 199.63 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.28 KB 10.28 KB 3.49 KB 3.49 KB UMD_PROD
ReactDOMTesting-dev.js -0.0% 0.0% 869.57 KB 869.15 KB 194.5 KB 194.56 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 🔺+0.1% 368.76 KB 368.88 KB 67.34 KB 67.43 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 49.52 KB 49.52 KB 13.55 KB 13.55 KB NODE_DEV
ReactDOMTesting-profiling.js 0.0% +0.1% 368.76 KB 368.88 KB 67.34 KB 67.43 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% 0.0% 128.57 KB 128.57 KB 34.05 KB 34.05 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.77 KB 20.77 KB 7.6 KB 7.6 KB NODE_PROD
react-dom.development.js -0.1% -0.0% 914.29 KB 913.75 KB 200.19 KB 200.16 KB UMD_DEV
react-dom-server.browser.development.js 0.0% 0.0% 138.15 KB 138.15 KB 35.19 KB 35.19 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.75 KB 119.8 KB 38.22 KB 38.23 KB UMD_PROD
react-dom.profiling.min.js 0.0% +0.1% 123.4 KB 123.45 KB 39.38 KB 39.41 KB UMD_PROFILING
react-dom.development.js -0.1% 0.0% 866.69 KB 866.2 KB 196.52 KB 196.54 KB NODE_DEV
react-dom-server.browser.development.js 0.0% 0.0% 127.45 KB 127.45 KB 33.83 KB 33.83 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.9 KB 119.95 KB 37.45 KB 37.46 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.36 KB 20.36 KB 7.45 KB 7.45 KB NODE_PROD
ReactDOM-prod.js 0.0% 🔺+0.1% 370.74 KB 370.86 KB 67.45 KB 67.52 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% +0.1% 381.95 KB 382.07 KB 69.57 KB 69.64 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 56.05 KB 56.05 KB 14.54 KB 14.54 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10 KB 10 KB 3.39 KB 3.38 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 708 B 707 B UMD_PROD

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer-server.development.js 0.0% -0.1% 1.82 KB 1.82 KB 863 B 862 B NODE_DEV
react-noop-renderer-server.production.min.js 0.0% -0.2% 877 B 877 B 498 B 497 B NODE_PROD
react-noop-renderer-persistent.development.js +2.2% +0.2% 26.94 KB 27.53 KB 5.52 KB 5.53 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 🔺+2.5% 🔺+0.7% 10.81 KB 11.08 KB 3.3 KB 3.32 KB NODE_PROD
react-noop-renderer.development.js +2.2% +0.3% 26.88 KB 27.47 KB 5.51 KB 5.52 KB NODE_DEV
react-noop-renderer-flight-client.development.js 0.0% -0.1% 1.43 KB 1.43 KB 733 B 732 B NODE_DEV
react-noop-renderer.production.min.js 🔺+2.5% 🔺+0.6% 10.79 KB 11.06 KB 3.29 KB 3.31 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against da83408

bvaughn
bvaughn approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Compared diff against changes from all 4 cherry picked PRs. Looks good.

Also downloaded CI artifacts from this branch and verified that the class component warnings are no longer triggered on a repro Sandbox.

@gaearon gaearon closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@acdlite @sizebot @bvaughn @gaearon @facebook-github-bot @JoviDeCroock