Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renderPhaseUpdates Map #17484

Merged
merged 3 commits into from Dec 14, 2019
Merged

Commits on Dec 13, 2019

  1. Configuration menu
    Copy the full SHA
    f14679f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6388040 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Discard render phase updates if component throws

    When aborting a render, we also need to throw out render phase updates.
    Remove the updates from the queues so they do not persist to the next
    render. We already did a single pass through the whole list of hooks, so
    we know that any pending updates must have been dispatched during the
    render phase. The ones that were dispatched before we started rendering
    were already transferred to the current hook's queue.
    acdlite committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    b384dd1 View commit details
    Browse the repository at this point in the history