Hooks Refactor Update Queue by Cloning Rebased Updates #17483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 89ca3cf:
|
Details of bundled changes.Comparing: 3c1efa0...89ca3cf react-reconciler
react-dom
react-art
react-test-renderer
react-native-renderer
ReactDOM: size: 🔺+0.3%, gzip: 🔺+0.2% Size changes (stable) |
Details of bundled changes.Comparing: 3c1efa0...89ca3cf react-dom
react-native-renderer
react-test-renderer
react-art
react-reconciler
Size changes (experimental) |
acdlite
reviewed
Nov 28, 2019
acdlite
reviewed
Nov 28, 2019
| } else { | ||
| first = last !== null ? last.next : null; | ||
| current.baseQueue = baseQueue = pendingQueue; | ||
| queue.pending = null; |
There was a problem hiding this comment.
I believe we could use this same trick for expirationTimes. By storing it temporarily on a shared stateful object and then transferring it to “current”. That way we don’t need the alternate model when we backtrack and can just backtrack along on a shared object path.
There was a problem hiding this comment.
Yeah I used a similar trick for the eager bailout optimization. Where I reset current.expirationTime to NoWork after a bailout. Also in my useTransition PR to clear a pending transition. Such a nice strategy.
|
We might want to add an optimization to avoid cloning the queue when something else renders at higher pri. In that case it’s unnecessary to clone it. |
This was referenced Dec 2, 2019
sebmarkbage
force-pushed
the
hooks-refactor-queue
branch
from
f3659c5
to
f8244b2
Compare
Adds a failing test case where an update that was committed is later skipped over during a rebase. This should never happen.
sebmarkbage
force-pushed
the
hooks-refactor-queue
branch
from
f8244b2
to
cb6ccda
Compare
sebmarkbage
force-pushed
the
hooks-refactor-queue
branch
from
cb6ccda
to
89ca3cf
Compare
acdlite
added a commit
that referenced
this pull request
Dec 9, 2019
Fixes a bug related to rebasing updates. Once an update has committed, it should never un-commit, even if interrupted by a higher priority update. The fix includes a refactor of how update queues work. This commit is a combination of two PRs: - #17483 by @sebmarkbage refactors the hook update queue - #17510 by @acdlite refactors the class and root update queue Landing one without the other would cause state updates to sometimes be inconsistent across components, so I've combined them into a single commit in case they need to be reverted. Co-authored-by: Sebastian Markbåge <sema@fb.com> Co-authored-by: Andrew Clark <git@andrewclark.io>
|
I squashed this with the class refactor and landed as b617db3 so it can be atomically reverted. |
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Dec 9, 2019
Fixes a bug related to rebasing updates. Once an update has committed, it should never un-commit, even if interrupted by a higher priority update. The fix includes a refactor of how update queues work. This commit is a combination of two PRs: - facebook#17483 by @sebmarkbage refactors the hook update queue - facebook#17510 by @acdlite refactors the class and root update queue Landing one without the other would cause state updates to sometimes be inconsistent across components, so I've combined them into a single commit in case they need to be reverted. Co-authored-by: Sebastian Markbåge <sema@fb.com> Co-authored-by: Andrew Clark <git@andrewclark.io>
acdlite
added a commit
that referenced
this pull request
Dec 11, 2019
* Refactor Update Queues to Fix Rebasing Bug Fixes a bug related to rebasing updates. Once an update has committed, it should never un-commit, even if interrupted by a higher priority update. The fix includes a refactor of how update queues work. This commit is a combination of two PRs: - #17483 by @sebmarkbage refactors the hook update queue - #17510 by @acdlite refactors the class and root update queue Landing one without the other would cause state updates to sometimes be inconsistent across components, so I've combined them into a single commit in case they need to be reverted. Co-authored-by: Sebastian Markbåge <sema@fb.com> Co-authored-by: Andrew Clark <git@andrewclark.io> * Initialize update queue object on mount Instead of lazily initializing update queue objects on the first update, class and host root queues are created on mount. This simplifies the logic for appending new updates and matches what we do for hooks.
Merged
This was referenced Mar 6, 2020
This was referenced Apr 23, 2020
This was referenced May 4, 2020
This was referenced Mar 8, 2021
This was referenced Mar 17, 2021
Bump react-test-renderer from 16.11.0 to 16.13.0
newerton/gostack-template-conceitos-react-native#21
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #17480.
Alternative to #17430.
This model splits the update queue into two (cyclic) linked lists. There is one each for current/workInProgress pair for rebase purposes. There is also one shared one.
When we process a queue we merge the shared onto the "current" one, and clone it onto the work in progress.
The cloned one doesn't include the beginning of the queue that is fully processed.
The cloned nodes that were processed get Sync priority so that they don't get dropped during future renders.