feat(controlsList): passing through Chrome's controlsList attribute #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Chrome allows an attribute 'controlsList', which allows you to blacklist certain controls, like the download button. This change passes the attribute through so that it can be used with ReactAudioPlayer. https://googlechrome.github.io/samples/media/controlslist.html
|
Just realised that React doesn't support this attribute yet: facebook/react#9594 Will reopen when it does. |
|
Bummer. Thanks for the PR anyway, I'm happy to update React and move forward with this when they do support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Chrome allows an attribute 'controlsList', which allows you to
blacklist certain controls, like the download button. This change passes
the attribute through so that it can be used with ReactAudioPlayer.
https://googlechrome.github.io/samples/media/controlslist.html