Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNGP - Move the generateAutolinkingNewArchitectureFiles task to core autolinking #44289

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RNGP - Move the generateAutolinkingNewArchitectureFiles task to core autolinking #44289

wants to merge 2 commits into from

Commits on Apr 30, 2024

  1. RNGP - Move generateAutolinkingPackageList to core autolinking 

    Summary:
This diff is part of RFC0759
react-native-community/discussions-and-proposals#759

Here I'm moving over the task to generate the Package List for Autolinking inside RNGP.
The logic is the same as this one:
https://github.com/react-native-community/cli/blob/73f880c3d87cdde81204364289f2f488a473c52b/packages/cli-platform-android/native_modules.gradle#L217

The class is generated as PackageList2 to avoid a duplicate class build failure with the current Autolinking from CLI.

Changelog:
[Internal] [Changed] - RNGP - Move generateAutolinkingPackageList to core autolinking

Differential Revision: D56637394
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    42f9129 View commit details
    Browse the repository at this point in the history

  2. RNGP - Move the generateAutolinkingNewArchitectureFiles task to core … 

    …autolinking

Summary:
This diff is part of RFC0759
react-native-community/discussions-and-proposals#759

Here I'm moving the New Architecture C++ Autolinking from the CLI to core.
It follows the same logic as this:
https://github.com/react-native-community/cli/blob/73f880c3d87cdde81204364289f2f488a473c52b/packages/cli-platform-android/native_modules.gradle#L544-L550

Changelog:
[Internal] [Changed] - RNGP - Move the generateAutolinkingNewArchitectureFiles task to core autolinking

Reviewed By: cipolleschi, blakef

Differential Revision: D55475594
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    493306f View commit details
    Browse the repository at this point in the history