RNGP - Move the generateAutolinkingNewArchitectureFiles task to core autolinking #44289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Summary: This diff is part of RFC0759 react-native-community/discussions-and-proposals#759 Here I'm moving over the task to generate the Package List for Autolinking inside RNGP. The logic is the same as this one: https://github.com/react-native-community/cli/blob/73f880c3d87cdde81204364289f2f488a473c52b/packages/cli-platform-android/native_modules.gradle#L217 The class is generated as PackageList2 to avoid a duplicate class build failure with the current Autolinking from CLI. Changelog: [Internal] [Changed] - RNGP - Move generateAutolinkingPackageList to core autolinking Differential Revision: D56637394
…autolinking Summary: This diff is part of RFC0759 react-native-community/discussions-and-proposals#759 Here I'm moving the New Architecture C++ Autolinking from the CLI to core. It follows the same logic as this: https://github.com/react-native-community/cli/blob/73f880c3d87cdde81204364289f2f488a473c52b/packages/cli-platform-android/native_modules.gradle#L544-L550 Changelog: [Internal] [Changed] - RNGP - Move the generateAutolinkingNewArchitectureFiles task to core autolinking Reviewed By: cipolleschi, blakef Differential Revision: D55475594
cortinico
force-pushed
the
export-D55475594
branch
from
f9c1511
to
493306f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is part of RFC0759
react-native-community/discussions-and-proposals#759
Here I'm moving the New Architecture C++ Autolinking from the CLI to core.
It follows the same logic as this:
https://github.com/react-native-community/cli/blob/73f880c3d87cdde81204364289f2f488a473c52b/packages/cli-platform-android/native_modules.gradle#L544-L550
Changelog:
[Internal] [Changed] - RNGP - Move the generateAutolinkingNewArchitectureFiles task to core autolinking
Differential Revision: D55475594