Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade deprecation error to warning #63

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Downgrade deprecation error to warning #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 13 additions & 13 deletions __tests__/PropTypesDevelopmentReact15.js
View file
Open in desktop
Expand Up @@ -100,11 +100,11 @@ function expectWarningInDevelopment(declaration, value) {
for (var i = 0; i < 3; i++) {
declaration(props, propName, componentName, 'prop');
}
expect(console.error.calls.count()).toBe(1);
expect(console.error.calls.argsFor(0)[0]).toContain(
expect(console.warn.calls.count()).toBe(1);
expect(console.warn.calls.argsFor(0)[0]).toContain(
'You are manually calling a React.PropTypes validation ',
);
console.error.calls.reset();
console.warn.calls.reset();
}

describe('PropTypesDevelopmentReact15', () => {
Expand Down Expand Up @@ -223,7 +223,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.array, /please/);
expectWarningInDevelopment(PropTypes.array, []);
expectWarningInDevelopment(PropTypes.array.isRequired, /please/);
Expand Down Expand Up @@ -287,7 +287,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.any, null);
expectWarningInDevelopment(PropTypes.any.isRequired, null);
expectWarningInDevelopment(PropTypes.any.isRequired, undefined);
Expand Down Expand Up @@ -383,7 +383,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.arrayOf({foo: PropTypes.string}), {
foo: 'bar',
});
Expand Down Expand Up @@ -450,7 +450,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.element, [<div />, <div />]);
expectWarningInDevelopment(PropTypes.element, <div />);
expectWarningInDevelopment(PropTypes.element, 123);
Expand Down Expand Up @@ -549,7 +549,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.instanceOf(Date), {});
expectWarningInDevelopment(PropTypes.instanceOf(Date), new Date());
expectWarningInDevelopment(PropTypes.instanceOf(Date).isRequired, {});
Expand Down Expand Up @@ -649,7 +649,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.node, 'node');
expectWarningInDevelopment(PropTypes.node, {});
expectWarningInDevelopment(PropTypes.node.isRequired, 'node');
Expand Down Expand Up @@ -764,7 +764,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.objectOf({foo: PropTypes.string}), {
foo: 'bar',
});
Expand Down Expand Up @@ -839,7 +839,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.oneOf(['red', 'blue']), true);
expectWarningInDevelopment(PropTypes.oneOf(['red', 'blue']), null);
expectWarningInDevelopment(PropTypes.oneOf(['red', 'blue']), undefined);
Expand Down Expand Up @@ -930,7 +930,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(
PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
[],
Expand Down Expand Up @@ -1028,7 +1028,7 @@ describe('PropTypesDevelopmentReact15', () => {
});

it('should warn if called manually in development', () => {
spyOn(console, 'error');
spyOn(console, 'warn');
expectWarningInDevelopment(PropTypes.shape({}), 'some string');
expectWarningInDevelopment(PropTypes.shape({foo: PropTypes.number}), {
foo: 42,
Expand Down
30 changes: 29 additions & 1 deletion factoryWithTypeCheckers.js
View file
Open in desktop
Expand Up @@ -16,6 +16,34 @@ var warning = require('fbjs/lib/warning');
var ReactPropTypesSecret = require('./lib/ReactPropTypesSecret');
var checkPropTypes = require('./checkPropTypes');

// We are inlining 'lowPriorityWarning' until it gets added to 'fbjs'
// https://github.com/facebook/fbjs/issues/239
const printWarning = function(format, ...args) {
var argIndex = 0;
var message = 'Warning: ' + format.replace(/%s/g, () => args[argIndex++]);
if (typeof console !== 'undefined') {
console.warn(message);
}
try {
// --- Welcome to debugging React ---
// This error was thrown as a convenience so that you can use this stack
// to find the callsite that caused this warning to fire.
throw new Error(message);
} catch (x) {}
};

const lowPriorityWarning = function(condition, format, ...args) {
if (format === undefined) {
throw new Error(
'`warning(condition, format, ...args)` requires a warning ' +
'message argument'
);
}
if (!condition) {
printWarning(format, ...args);
}
};

module.exports = function(isValidElement, throwOnDirectAccess) {
/* global Symbol */
var ITERATOR_SYMBOL = typeof Symbol === 'function' && Symbol.iterator;
Expand Down Expand Up @@ -171,7 +199,7 @@ module.exports = function(isValidElement, throwOnDirectAccess) {
// Avoid spamming the console because they are often not actionable except for lib authors
manualPropTypeWarningCount < 3
) {
warning(
lowPriorityWarning(
false,
'You are manually calling a React.PropTypes validation ' +
'function for the `%s` prop on `%s`. This is deprecated ' +
Expand Down