Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade deprecation error to warning #63

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on May 24, 2017

  1. Downgrade deprecation error to warning

    **what is the change?:**
    Inlines a version of 'warning' that uses `console.warn` instead of `console.error`, and then uses that for the deprecation warning.
    
    **NOTE: I'm not sure that this will only warn in development, which is a problem. We don't seem to have a '__DEV__' env. variable set up here, so I'm not sure how to limit the warnings to development?**
    
    **why make this change?:**
    This is a particularly noisy warning that was firing in 3rd party libraries, which then causes it to show up in product code. Users then can't silence it easily without updating their library. This makes it slightly less painful, hopefully, but still painful enough to get folks to update their code.
    
    **test plan:**
    `yarn test` - updated some tests to check for this.
    
    **issue:**
    facebook/react#9398
    flarnie committed May 24, 2017
    Configuration menu
    Copy the full SHA
    cb68864 View commit details
    Browse the repository at this point in the history