Replace deprecated uglify-es with uglify-js
#793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Hi @Simek - thanks for the PR. It's a duplicate of #661 though, and the reason that hasn't been merged is that the minified output of We're planning to switch Metro's default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the deprecated
uglify-espackage (https://www.npmjs.com/package/uglify-es) with theuglify-jsas suggested in the deprecation notice.Affected packages are
metro-minify-uglifyandmetro-source-map.It looks like the switch should be quite trouble free, since there are almost no difference between packages APIs.
Test plan
I have updated the dependencies and code, then I run the
testscript from the workspace root.