Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN preset: support async iterators, for await of #747

Closed
wants to merge 4 commits into from
Closed

RN preset: support async iterators, for await of #747

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4a3974
Support async iterators, for await of
newyankeecodeshop Dec 4, 2021
7466b31
Add unit test
newyankeecodeshop Dec 4, 2021
d0345f9
Support both Hermes and JSC
newyankeecodeshop Dec 5, 2021
27144cd
Test should use default transform profile
newyankeecodeshop Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/metro-react-native-babel-preset/package.json
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@
"license": "MIT",
"dependencies": {
"@babel/core": "^7.14.0",
"@babel/plugin-proposal-async-generator-functions": "^7.0.0",
"@babel/plugin-proposal-class-properties": "^7.0.0",
"@babel/plugin-proposal-export-default-from": "^7.0.0",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.0.0",
Expand Down
11 changes: 9 additions & 2 deletions packages/metro-react-native-babel-preset/src/configs/main.js
View file
Open in desktop
Expand Up @@ -114,8 +114,15 @@ const getPreset = (src, options) => {
{loose: true}, // dont 'a'.concat('b'), just use 'a'+'b'
]);
}
if (isHermes && (isNull || src.indexOf('async') !== -1)) {
extraPlugins.push([require('@babel/plugin-transform-async-to-generator')]);
if (isNull || src.indexOf('async') !== -1) {
extraPlugins.push([
require('@babel/plugin-proposal-async-generator-functions'),
]);
if (isHermes) {
extraPlugins.push([
require('@babel/plugin-transform-async-to-generator'),
]);
}
}
if (!isHermes && (isNull || src.indexOf('**') !== -1)) {
extraPlugins.push([
Expand Down
26 changes: 26 additions & 0 deletions packages/metro-transform-worker/src/__tests__/__snapshots__/index-test.js.snap
View file
Open in desktop
Expand Up @@ -272,6 +272,32 @@ Object {
}
`;

exports[`transforms async generators 1`] = `
"__d(function (global, _$$_REQUIRE, _$$_IMPORT_DEFAULT, _$$_IMPORT_ALL, module, exports, _dependencyMap) {
var _interopRequireDefault = _$$_REQUIRE(_dependencyMap[0], \\"@babel/runtime/helpers/interopRequireDefault\\");

Object.defineProperty(exports, \\"__esModule\\", {
value: true
});
exports.test = test;

var _awaitAsyncGenerator2 = _interopRequireDefault(_$$_REQUIRE(_dependencyMap[1], \\"@babel/runtime/helpers/awaitAsyncGenerator\\"));

var _wrapAsyncGenerator2 = _interopRequireDefault(_$$_REQUIRE(_dependencyMap[2], \\"@babel/runtime/helpers/wrapAsyncGenerator\\"));

function test() {
return _test.apply(this, arguments);
}

function _test() {
_test = (0, _wrapAsyncGenerator2.default)(function* () {
yield \\"ok\\";
});
return _test.apply(this, arguments);
}
});"
`;

exports[`transforms import/export syntax when experimental flag is on 1`] = `
Array [
Array [
Expand Down
30 changes: 30 additions & 0 deletions packages/metro-transform-worker/src/__tests__/index-test.js
View file
Open in desktop
Expand Up @@ -211,6 +211,36 @@ it('transforms an es module with regenerator', async () => {
]);
});

it('transforms async generators', async () => {
const result = await Transformer.transform(
baseConfig,
'/root',
'local/file.js',
'export async function* test() { yield "ok"; }',
{
dev: true,
type: 'module',
unstable_transformProfile: 'hermes-stable',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this line and test the default transform profile instead? Alternatively we can have a separate test for hermes-stable, but the main test should exercise the default profile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do

},
);

expect(result.output[0].data.code).toMatchSnapshot();
expect(result.dependencies).toEqual([
{
data: expect.objectContaining({asyncType: null}),
name: '@babel/runtime/helpers/interopRequireDefault',
},
{
data: expect.objectContaining({asyncType: null}),
name: '@babel/runtime/helpers/awaitAsyncGenerator',
},
{
data: expect.objectContaining({asyncType: null}),
name: '@babel/runtime/helpers/wrapAsyncGenerator',
},
]);
});

it('transforms import/export syntax when experimental flag is on', async () => {
const contents = ['import c from "./c";'].join('\n');

Expand Down
9 changes: 9 additions & 0 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -383,6 +383,15 @@
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.15.7.tgz#0c3ed4a2eb07b165dfa85b3cc45c727334c4edae"
integrity sha512-rycZXvQ+xS9QyIcJ9HXeDWf1uxqlbVFAUq0Rq0dbc50Zb/+wUe/ehyfzGfm9KZZF0kBejYgxltBXocP+gKdL2g==

"@babel/plugin-proposal-async-generator-functions@^7.0.0":
version "7.13.15"
resolved "https://registry.yarnpkg.com/@babel/plugin-proposal-async-generator-functions/-/plugin-proposal-async-generator-functions-7.13.15.tgz#80e549df273a3b3050431b148c892491df1bcc5b"
integrity sha512-VapibkWzFeoa6ubXy/NgV5U2U4MVnUlvnx6wo1XhlsaTrLYWE0UFpDQsVrmn22q5CzeloqJ8gEMHSKxuee6ZdA==
dependencies:
"@babel/helper-plugin-utils" "^7.13.0"
"@babel/helper-remap-async-to-generator" "^7.13.0"
"@babel/plugin-syntax-async-generators" "^7.8.4"

"@babel/plugin-proposal-class-properties@^7.0.0":
version "7.13.0"
resolved "https://registry.yarnpkg.com/@babel/plugin-proposal-class-properties/-/plugin-proposal-class-properties-7.13.0.tgz#146376000b94efd001e57a40a88a525afaab9f37"
Expand Down