Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more info to the getPolyfills function #1071

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

EvanBacon
Copy link
Contributor

Summary

We use getPolyfills in Expo CLI to supply custom global setup for Node.js environments. Currently, these polyfills are applied to bundles for both client and server web environments. This PR would supply additional info that we can use to pick polyfills.

Test plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2023
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 31, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (3be0f8f) 83.39% compared to head (77e7301) 83.39%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files         209      209           
  Lines       10835    10835           
  Branches     2725     2725           
=======================================
  Hits         9036     9036           
  Misses       1799     1799           
Files Changed Coverage Δ
packages/metro/src/lib/getPrependedScripts.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robhogan
Copy link
Contributor

Sorry about the delay with this one. At first glance it seems a bit arbitrary to add customTransformOptions to this (and not other config), but it's a valid use case and fits with future extensions, so I think we can get this in.

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants