RN preset: support async iterators, for await of #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Happy New Year @motiz88 are you able to review this? |
|
Hi @rh389 , can you or someone at Meta give this a look please? I'm happy to make changes or close it if you're not interested in metro including support for async iterators. |
|
Pulling this in for a closer look - thanks! |
|
@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
motiz88
reviewed
Jan 17, 2022
| { | ||
| dev: true, | ||
| type: 'module', | ||
| unstable_transformProfile: 'hermes-stable', |
There was a problem hiding this comment.
Can we remove this line and test the default transform profile instead? Alternatively we can have a separate test for hermes-stable, but the main test should exercise the default profile.
There was a problem hiding this comment.
Sure, will do
|
@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ericanderson
added a commit
to ericanderson/metro
that referenced
this pull request
Feb 9, 2022
* upstream/main: Use node devtools url (facebook#761) Publish 0.68.0 fix(website): add Algolia search API key (facebook#726) Change github actions trigger to use `main` branch (facebook#769) RN preset: support async iterators, for await of (facebook#747) Deploy 0.171.0 to xplat
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Mar 14, 2022
Summary: **Summary** Async Generators and `for await` are part of ES2018. This PR adds `plugin-proposal-async-generator-functions` to the react native preset. See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions Fixes facebook#551 **Test plan** I added a test `transforms async generators` to `index-test.js`. Pull Request resolved: facebook#747 Reviewed By: motiz88 Differential Revision: D33621536 Pulled By: rh389 fbshipit-source-id: 0e07e6132e894fb5ad455627c2a33674f904a2fc
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 21, 2022
Summary: **Summary** Async Generators and `for await` are part of ES2018. This PR adds `plugin-proposal-async-generator-functions` to the react native preset. See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions Fixes facebook#551 **Test plan** I added a test `transforms async generators` to `index-test.js`. Pull Request resolved: facebook#747 Reviewed By: motiz88 Differential Revision: D33621536 Pulled By: rh389 fbshipit-source-id: 0e07e6132e894fb5ad455627c2a33674f904a2fc
nevilm-lt
pushed a commit
to nevilm-lt/metro
that referenced
this pull request
Apr 22, 2022
Summary: **Summary** Async Generators and `for await` are part of ES2018. This PR adds `plugin-proposal-async-generator-functions` to the react native preset. See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions Fixes facebook#551 **Test plan** I added a test `transforms async generators` to `index-test.js`. Pull Request resolved: facebook#747 Reviewed By: motiz88 Differential Revision: D33621536 Pulled By: rh389 fbshipit-source-id: 0e07e6132e894fb5ad455627c2a33674f904a2fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Async Generators and
for awaitare part of ES2018. This PR addsplugin-proposal-async-generator-functionsto the react native preset.See https://babeljs.io/docs/en/babel-plugin-proposal-async-generator-functions
Fixes #551
Test plan
I added a test
transforms async generatorstoindex-test.js.