Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): mobile navbar & skipToContent should cover announcementBar #8163

Merged
merged 3 commits into from Oct 6, 2022
Merged

fix(theme): mobile navbar & skipToContent should cover announcementBar #8163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7aaebf
fix: stack navbar on top so that the banner doesn't cover the navbar.
adnanhashmi09 Oct 2, 2022
a84133d
Revert "fix: stack navbar on top so that the banner doesn't cover the…
slorber Oct 6, 2022
1a2039e
revert z-index/shadow change from https://github.com/facebook/docusau…
slorber Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/AnnouncementBar/styles.module.css
View file
Open in desktop
Expand Up @@ -15,8 +15,16 @@
height: var(--docusaurus-announcement-bar-height);
background-color: var(--ifm-color-white);
color: var(--ifm-color-black);

/*
Unfortunately we can't make announcement bar render above the navbar
IE need to use border-bottom instead of shadow
See https://github.com/facebookincubator/infima/issues/275

box-shadow: var(--ifm-global-shadow-lw);
z-index: calc(var(--ifm-z-index-fixed) + 1); /* just above the navbar */
z-index: calc(var(--ifm-z-index-fixed) + 1);
*/
border-bottom: 1px solid var(--ifm-color-emphasis-100);
}

html[data-announcement-bar-initially-dismissed='true'] .announcementBar {
Expand Down