Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): mobile navbar & skipToContent should cover announcementBar #8163

Merged
merged 3 commits into from Oct 6, 2022

Conversation

adnanhashmi09
Copy link
Contributor

@adnanhashmi09 adnanhashmi09 commented Oct 2, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

In mobile view the announcement banner covered the navbar. It has been fixed and the navbar is stacked on top so that the banner doesnt cover it anymore.

Test Plan

Test links

Deploy preview: https://deploy-preview-8163--docusaurus-2.netlify.app/

Related issues/PRs

Closes #8141

@netlify
Copy link

netlify bot commented Oct 2, 2022

[V2]

Name Link
🔨 Latest commit 1a2039e
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/633ed1d3576bfc0009774876
😎 Deploy Preview https://deploy-preview-8163--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 81 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report

@adnanhashmi09
Copy link
Contributor Author

@slorber Please review this PR and let me know if you want any changes.

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 6, 2022
@slorber
Copy link
Collaborator

slorber commented Oct 6, 2022

Thanks

Unfortunately it's not a good fix because it defeats the purpose of a change I did to make it possible to add a shadow to the announcement banner here: #7940

With this fix, the shadow is always covered by the navbar.

Will look for a better solution and edit a bit this PR

Also need to consider this: #8173

@slorber slorber linked an issue Oct 6, 2022 that may be closed by this pull request
7 tasks
@slorber
Copy link
Collaborator

slorber commented Oct 6, 2022

Thanks for giving it a try.

Unfortunately after studying the problem I come to the conclusion that some Infima refactor is required to achieve what I want (facebookincubator/infima#275) and the best solution is to temporarily revert my changes made here: #7940

Will do that in this PR so that you'll be credited for your attempt as well 👍

@adnanhashmi09
Copy link
Contributor Author

Thank you for the review.
If there is anything I can do to help with this issue, do let me know.

@slorber slorber changed the title fix: stack navbar on top so that the banner doesn't cover the navbar. fix(theme): mobile navbar & skipToContent should cover announcementBar Oct 6, 2022
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Oct 6, 2022
@slorber slorber merged commit c325f87 into facebook:main Oct 6, 2022
slorber added a commit that referenced this pull request Oct 28, 2022
#8163)

Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Announcement bar covers 'Skip to main content' button Banner covers menu on mobile
3 participants