Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore json files from TypeScript type checking #5614

Merged
merged 1 commit into from Oct 29, 2018
Merged

Ignore json files from TypeScript type checking #5614

merged 1 commit into from Oct 29, 2018

Conversation

brunolemos
Copy link
Contributor

@brunolemos brunolemos commented Oct 29, 2018 •
edited

Fix #5613

Sound's like another typescript bug. Opened microsoft/TypeScript#28202

@Timer
Copy link
Contributor

Timer commented Oct 29, 2018

Do we have an open issue with typescript about this? Can you link it here please?

@brunolemos
Copy link
Contributor Author

brunolemos commented Oct 29, 2018 •
edited

microsoft/TypeScript#28202

I was just trying to create a codesandbox before opening an issue on TypeScript but I'm not being able to make tsx work there: https://codesandbox.io/s/xl1y2vjwk4

@Timer
Copy link
Contributor

Timer commented Oct 29, 2018

Awesome!

@Timer
Copy link
Contributor

Timer commented Oct 29, 2018

I don't think codesandbox has support for TypeScript yet, maybe try just .ts and don't use JSX?

@Timer Timer added this to the 2.1 milestone Oct 29, 2018
@Timer Timer merged commit feea693 into facebook:master Oct 29, 2018
@brunolemos
Copy link
Contributor Author

Didn't work, but nevermind, codesandbox wouldn't show this error output anyway because it's from the typescript compiler

@brunolemos
Copy link
Contributor Author

brunolemos commented Oct 29, 2018 •
edited

CodeSandbox will deploy a fix tomorrow: codesandbox/codesandbox-client#1239

TypeScript has already fixed and merged after just a few hours: microsoft/TypeScript#28207

The community is so great 💙

@Timer
Copy link
Contributor

Timer commented Oct 29, 2018

I guess we should revert this once that's released?

@brunolemos
Copy link
Contributor Author

Not released yet, just merged. Maybe on 3.1.4.

@Timer
Copy link
Contributor

Timer commented Oct 29, 2018

We'll keep this behavior until CRA 3.0.

@Timer Timer mentioned this pull request Oct 29, 2018
Closed
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@brunolemos @Timer
Ignore json files from TypeScript type checking (facebook#5614)
54c107d 
Fix facebook#5613
@brunolemos
Copy link
Contributor Author

TypeScript 3.1.4 released; I didn't confirm if the fix was included.

nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
@brunolemos @nate770
Ignore json files from TypeScript type checking (facebook#5614)
cde4e88 
Fix facebook#5613
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunolemos @Timer @facebook-github-bot