Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check JSON files #5619

Closed
Timer opened this issue Oct 29, 2018 · 3 comments · Fixed by #6615
Closed

Type check JSON files #5619

Timer opened this issue Oct 29, 2018 · 3 comments · Fixed by #6615
Labels
issue: typescript tag: breaking change tag: enhancement
Projects
v3
Milestone
3.0

Comments

@Timer
Copy link
Contributor

Timer commented Oct 29, 2018

Revert #5614
@Timer Timer added this to the 3.0 milestone Oct 29, 2018
@feysalikbal
Copy link

Hi, I want to work on this task.

@Timer
Copy link
Contributor Author

Timer commented Oct 30, 2018

@feysalikbal we appreciate the enthusiasm but we already have a PR lined up for this (just reverting one)!

However, this can't be merged until we're ready to release v3.

Hopefully you can find something else to contribute to, we look forward to it!

@feysalikbal
Copy link

OK Thanks :)

@iansu iansu added this to To do in v3 Mar 10, 2019
@ianschmitz ianschmitz mentioned this issue Mar 10, 2019
Merged
@ianschmitz ianschmitz moved this from To do to In progress in v3 Mar 10, 2019
v3 automation moved this from In progress to Done Mar 11, 2019
@lock lock bot locked and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: typescript tag: breaking change tag: enhancement
Projects
No open projects
v3
  
Done
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Allow .json type checking ianschmitz/create-react-app
2 participants
@Timer @feysalikbal