Remove ESLint verification when opting-out #10499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansu
reviewed
Feb 4, 2021
| 'jest', | ||
| 'webpack', | ||
| 'webpack-dev-server', | ||
| ]; | ||
|
|
||
| if (isESLintPluginEnabled) { | ||
| depsToCheck = [...depsToCheck, 'babel-eslint', 'eslint']; |
There was a problem hiding this comment.
You might as well just push eslint and babel-eslint into the array and then you can avoid spreading and reassigning the previous value. That's how I would do it anyway, but I don't feel strongly about this.
There was a problem hiding this comment.
I don't disagree, it's a stylistic thing. Most of my the projects I work on are written to avoid mutation... and I just do it by default now.
There was a problem hiding this comment.
This was updated to use filter(Boolean) instead, as we do in other places.
mrmckeb
force-pushed
the
feature/update-eslint-verify-checks
branch
from
0b0265d
to
96fa29f
Compare
mrmckeb
force-pushed
the
feature/update-eslint-verify-checks
branch
from
96fa29f
to
2a7c931
Compare
|
I've tested this again today by using ESLint 7.10.0. When the flag is not set: There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.
The react-scripts package provided by Create React App requires a dependency:
"eslint": "^7.11.0"
Don't try to install it manually: your package manager does it automatically.
However, a different version of eslint was detected higher up in the tree:
/Users/mrmckeb/Development/temp/cra-test/node_modules/eslint (version: 7.10.0)With the flag CRA starts with no errors as expected. |
iansu
approved these changes
Jun 2, 2021
sumanthratna
pushed a commit
to sumanthratna/create-react-app
that referenced
this pull request
Aug 4, 2021
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #10170 and ensures that we no longer "verify"
eslintandbabel-eslintversions if the user has opted out of the plugin completely.Related comment: #10170 (comment)