Skip to content

Commit

Permalink
Remove ESLint verification when opting-out (facebook#10499)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrmckeb authored and abhiisheek committed May 24, 2023
1 parent 761a325 commit f84ac91
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions packages/react-scripts/scripts/utils/verifyPackageTree.js
Expand Up @@ -13,6 +13,8 @@ const fs = require('fs');
const semver = require('semver');
const path = require('path');

const isESLintPluginEnabled = process.env.DISABLE_ESLINT_PLUGIN !== 'true';

// We assume that having wrong versions of these
// in the tree will likely break your setup.
// This is a relatively low-effort way to find common issues.
Expand All @@ -21,14 +23,15 @@ function verifyPackageTree() {
// These are packages most likely to break in practice.
// See https://github.com/facebook/create-react-app/issues/1795 for reasons why.
// I have not included Babel here because plugins typically don't import Babel (so it's not affected).
'babel-eslint',
'babel-jest',
'babel-loader',
'eslint',
'jest',
'webpack',
'webpack-dev-server',
];
isESLintPluginEnabled && 'babel-eslint',
isESLintPluginEnabled && 'eslint',
].filter(Boolean);

// Inlined from semver-regex, MIT license.
// Don't want to make this a dependency after ejecting.
const getSemverRegex = () =>
Expand Down

0 comments on commit f84ac91

Please sign in to comment.