Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4666: addressing okhttp sources needing explicit close #4665

Merged
merged 3 commits into from Dec 13, 2022
Merged

fix #4666: addressing okhttp sources needing explicit close #4665

merged 3 commits into from Dec 13, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Dec 12, 2022 •
edited by manusa

Description

Fixes #4666 the AsyncBody implementation even after reading to exhaustion still needs to close the source to satisfy okhttp.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins requested a review from manusa December 12, 2022 21:05
@shawkins shawkins changed the title fix #4665: addressing okhttp sources needing explicit close fix #4666: addressing okhttp sources needing explicit close Dec 12, 2022
@manusa manusa added this to the 6.3.1 milestone Dec 13, 2022
manusa and others added 2 commits December 13, 2022 13:35
@manusa
test: added connection leakage test for OkHttp
82e98b3 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@shawkins
Merge pull request #10 from manusa/review_okhttp_close
562dd65 
test: added connection leakage test for OkHttp
@manusa manusa mentioned this pull request Dec 13, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit e30ac34 into fabric8io:master Dec 13, 2022
@shawkins shawkins mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.1
Development

Successfully merging this pull request may close these issues.

OkHttp responses not closed properly
2 participants
@shawkins @manusa