-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: added connection leakage test for OkHttp
Signed-off-by: Marc Nuri <marc@marcnuri.com>
- Loading branch information
Showing
6 changed files
with
147 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
...t-okhttp/src/test/java/io/fabric8/kubernetes/client/okhttp/ConnectionPoolLeakageTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
/** | ||
* Copyright (C) 2015 Red Hat, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.fabric8.kubernetes.client.okhttp; | ||
|
||
import io.fabric8.kubernetes.client.http.AsyncBody; | ||
import io.fabric8.kubernetes.client.http.HttpClient; | ||
import io.fabric8.kubernetes.client.http.HttpResponse; | ||
import okhttp3.ConnectionPool; | ||
import okhttp3.Protocol; | ||
import okhttp3.mockwebserver.MockResponse; | ||
import okhttp3.mockwebserver.MockWebServer; | ||
import org.junit.jupiter.api.AfterEach; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.provider.ValueSource; | ||
|
||
import java.util.Arrays; | ||
import java.util.Collections; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
class ConnectionPoolLeakageTest { | ||
|
||
private MockWebServer server; | ||
|
||
private ConnectionPool connectionPool; | ||
private OkHttpClientBuilderImpl clientBuilder; | ||
|
||
@BeforeEach | ||
void setUp() { | ||
server = new MockWebServer(); | ||
final char[] chars = new char[10485760]; | ||
Arrays.fill(chars, '1'); | ||
server.enqueue(new MockResponse().setResponseCode(200).setChunkedBody(new String(chars), 1024)); | ||
connectionPool = new ConnectionPool(10, 100, TimeUnit.SECONDS); | ||
clientBuilder = new OkHttpClientFactory().newBuilder(); | ||
clientBuilder.getBuilder().connectionPool(connectionPool); | ||
} | ||
|
||
@AfterEach | ||
void tearDown() throws Exception { | ||
server.shutdown(); | ||
connectionPool.evictAll(); | ||
} | ||
|
||
@ParameterizedTest(name = "with protocol {0}") | ||
@DisplayName("consumeBytes should not leak connections") | ||
@ValueSource(strings = { "h2_prior_knowledge", "http/1.1" }) | ||
void consumeBytes(String protocol) throws Exception { | ||
final Protocol p = Protocol.get(protocol); | ||
server.setProtocols(Collections.singletonList(p)); | ||
server.start(); | ||
clientBuilder.getBuilder().protocols(Collections.singletonList(p)); | ||
try (HttpClient httpClient = clientBuilder.build()) { | ||
final HttpResponse<AsyncBody> asyncBodyResponse = httpClient.consumeBytes( | ||
httpClient.newHttpRequestBuilder().uri(server.url("/").toString()).build(), | ||
(value, asyncBody) -> { | ||
asyncBody.consume(); | ||
}) | ||
.get(10L, TimeUnit.SECONDS); | ||
assertThat(activeConnections()).isEqualTo(1); | ||
asyncBodyResponse.body().consume(); | ||
asyncBodyResponse.body().done().get(10L, TimeUnit.SECONDS); | ||
assertThat(activeConnections()).isZero(); | ||
} | ||
} | ||
|
||
private int activeConnections() { | ||
return connectionPool.connectionCount() - connectionPool.idleConnectionCount(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...ent-okhttp/src/test/java/io/fabric8/kubernetes/client/okhttp/OkHttpImplAsyncBodyTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/** | ||
* Copyright (C) 2015 Red Hat, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.fabric8.kubernetes.client.okhttp; | ||
|
||
import okio.BufferedSource; | ||
import org.junit.jupiter.api.Test; | ||
import org.mockito.Mockito; | ||
|
||
import java.nio.ByteBuffer; | ||
import java.util.List; | ||
|
||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.when; | ||
|
||
class OkHttpImplAsyncBodyTest { | ||
|
||
@Test | ||
void testClosedWhenExhausted() throws Exception { | ||
BufferedSource source = mock(BufferedSource.class); | ||
when(source.exhausted()).thenReturn(true); | ||
OkHttpClientImpl.OkHttpAsyncBody<List<ByteBuffer>> asyncBody = new OkHttpClientImpl.OkHttpAsyncBody<List<ByteBuffer>>(null, | ||
source, | ||
Runnable::run) { | ||
|
||
@Override | ||
protected List<ByteBuffer> process(BufferedSource source) { | ||
return null; | ||
} | ||
}; | ||
|
||
asyncBody.consume(); | ||
Mockito.verify(source).close(); | ||
} | ||
} |