fix (kubernetes-model-generator) : Update Kubernetes Model to v1.25.0 (#4347) #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oscerd
approved these changes
Sep 1, 2022
rohanKanojia
force-pushed
the
pr/issue4327-kubernetes-model-generator
branch
5 times, most recently
from
f39133d
to
e64c331
Compare
|
Please add support for apiVersion autoscaling/v2 since now is using Fabric8 Kubernetes Client 5.11.2 which doesn't seem to have it. |
rohanKanojia
force-pushed
the
pr/issue4327-kubernetes-model-generator
branch
from
e64c331
to
f977a14
Compare
…ert integer array to string Kubernetes Model Generator script currently converted all byte, integer lists to string (since there is no byte reflect.type in GoLang , it's alias to `uint8`). This seems to be incorrectly generating PodFailurePolicyOnExitCodesRequirement.values field as String. Add a switch case in `javaType()` to treat `reflect.Uint8` to byte. Limit `javaTypeArrayList()` to only convert byte array/ `reflect.Uint8` array to string. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
+ Update Kubernetes Model to v1.25.0 + Add autoscaling/v2 HorizontalPodAutoscaler model and DSL + Force `containerd/containerd`, `docker/distribution` and `opencontainers/image-spec` to not use vulnerable versions (fabric8io#4327) Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Run integration tests on Kubernetes 1.25.0 as well Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue4327-kubernetes-model-generator
branch
from
f977a14
to
9f1cc2d
Compare
|
SonarCloud Quality Gate failed. |
manusa
reviewed
Sep 21, 2022
| @@ -29,6 +30,7 @@ | |||
| import static org.junit.jupiter.api.Assertions.assertTrue; | |||
|
|
|||
| @LoadKubernetesManifests("/cronjob-it.yml") | |||
| @RequireK8sSupport(CronJob.class) | |||
There was a problem hiding this comment.
Follow-up update this test to use CronJob v1 instead
manusa
reviewed
Sep 21, 2022
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| @LoadKubernetesManifests("/pod-evict-it.yml") | ||
| @RequireK8sSupport(PodDisruptionBudget.class) |
There was a problem hiding this comment.
Is there any reason why this new test is based on v1beta1 of PodDisruptionBudget?
There was a problem hiding this comment.
This isn't a new test. This was earlier part of PodIT . This test was breaking on Kubernetes 1.25 hence I moved it to separate class with a RequireK8sSupport condition
There was a problem hiding this comment.
Follow-up: update this test to use PodDisruptionBudget v1 instead
manusa
approved these changes
Sep 21, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #4327 #4347
clusterNameremoved from ObjectMetak8s.io/api/flowcontrol/v1beta2API (they were present earlier too, just realized it a bit late)autoscaling/v2HorizontalPodAutoscaler model and DSLcontainerd/containerd,docker/distributionandopencontainers/image-specto not use vulnerable versions (Fix Dependabot reported alerts in go modules #4327)uint8). This seems to be incorrectly generating PodFailurePolicyOnExitCodesRequirement.values field as String. Add a switch case injavaType()to treatreflect.Uint8to byte. LimitjavaTypeArrayList()to only convert byte array/reflect.Uint8array to string.Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist