Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not discard auth command if no args #4122

Closed
wants to merge 8 commits into from
Closed

Do not discard auth command if no args #4122

wants to merge 8 commits into from

Conversation

markusheiden
Copy link
Contributor

@markusheiden markusheiden commented May 5, 2022 •
edited

Description

The authentication command (user.exec.args: command) from the .kube/config won't be discarded if no arguments are specified (user.exec.args: null).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

I have no OpenShift so I was not able to test that.

Fixes #3733

@markusheiden markusheiden marked this pull request as ready for review May 5, 2022 21:05
@markusheiden markusheiden mentioned this pull request May 5, 2022
Closed
11 tasks
@markusheiden
Copy link
Contributor Author

When do you plan a release of the 5.12 branch?

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@manusa manusa deleted the branch fabric8io:5.12 July 28, 2022 09:13
@manusa manusa closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markusheiden @manusa