Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoupling unmatched handling from kubernetesdeserializer #4034

Closed
wants to merge 1 commit into from

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Apr 4, 2022

Description

As either a stand alone change or part of one of the other serialization issues #3972 or #4024 I'd like to remove the coupling between the KubernetesDeserializer and the unmatched property handling. This change elevates that to the Serialization level. This will further allow us to change the handling of parsing / processing parameters - that has been embedded down in the serialization layer as raw string processing, but it doesn't need to be. Parsing with unmatched type handling on, or parsing as a map would allow for post processing of property substitution.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

67.6% 67.6% Coverage
0.0% 0.0% Duplication

@shawkins shawkins added the wip label Apr 7, 2022
@shawkins
Copy link
Contributor Author

shawkins commented Apr 7, 2022

@manusa marking as a WIP, since we probably won't make it far with cleaning up the static nature of KubernetesDeserializer, it isn't imperative to make this change just yet.

@manusa
Copy link
Member

manusa commented Jun 5, 2022

Does #4171 address the issues that this PR tries to fix?
(I feel really uncomfortable extending the ObjectMapper.)

@shawkins
Copy link
Contributor Author

shawkins commented Jun 6, 2022

Does #4171 address the issues that this PR tries to fix?

No, this pr is more general. It would have addressed #4171 as well as the ability to do something like client.templates().list() - when you have non-string parameters (currently that will throw a parsing exception), and eventually fully decouple the template processing from parsing (that currently requires simple string substitution prior to parsing).

@shawkins
Copy link
Contributor Author

Replaced by #4109

@shawkins shawkins closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants