Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization.clone is not valid for non-KubernetesResource objects #4171

Closed
shawkins opened this issue May 25, 2022 · 0 comments
Closed

Serialization.clone is not valid for non-KubernetesResource objects #4171

shawkins opened this issue May 25, 2022 · 0 comments
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

It's not clear from the method signature / javadocs, but clone is currently only good for KubernetesResources due to the typing logic that will default to KubernetesResource.class. The signature should be tightened, or the implementation should allow for other types. This could also indirectly be fixed by #4034
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
@shawkins
fix fabric8io#4171: limiting clone to kubernetesresources
a75e2ba
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 25, 2022
@shawkins
fix fabric8io#4171: allowing any object in clone
ea5c8fe
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Jun 5, 2022
@shawkins @manusa
fix fabric8io#4171: allowing any object in clone
8ce54d1
@manusa manusa closed this as completed in 3316e8c Jun 5, 2022
@manusa manusa added this to the 6.0.0 milestone Jun 5, 2022
@manusa manusa mentioned this issue Jun 5, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@manusa @shawkins