[java-gen] - Generated Java model should include new specific annotations (min, max, etc.)

[fabiobrz]

Is your enhancement related to a problem? Please describe

Support for specific annotations (e.g.: @Max, @Min, @Pattern, etc.), was added recently but the Java generator doesn't generate any of such annotations.

Describe the solution you'd like

The Java generator should take the related keywords into account when they appear in CRDs (e.g.: maximum, minimum, pattern, etc.), and generate the corresponding annotations for them to appear in the Java model.

Describe alternatives you've considered

N/A

Additional context

See:

• Introduce specific annotations for the generators and specifically Introduce specific annotations for the generators #4348 (comment)
• Add support for Min, Max, Pattern and Nullable on CRD generator fields

[derlin]

Those new annotations look great !
I see you did a release of the kubernetes-client, but the generator-annotations module isn't available on maven central (marked as internal). Given the doc has been updated and references the io.fabric8.generator.*, it is quite confusing ^^'. I am still not able to import them, so how am I supposed to use this new feature ?

[andreaTP]

@derlin which version are you using?
The Java generator is available only 6+

[derlin]

@andreaTP I am using 5.13.3 and tried the latest version (5.13.4). Maybe this is where I am confused, then. Could you explain the difference between the 5.x and 6.x tracks ?

Edit: just tried importing the crd-generator-api and crd-generator-apt version 6.1.1, still unable to import.

[andreaTP]

I actually cannot find generator-annotations even for version 6.1.1 : https://repo1.maven.org/maven2/io/fabric8/ ( crd-generator is fine instead)
@manusa was it ever shipped?

Regarding the difference you can read more here: https://developers.redhat.com/articles/2022/07/15/new-http-clients-java-generator-and-more-fabric8-600

[manusa]

This is part of the 6.2.0 milestone, it will be available once we cut this release.

[bachmanity1]

This is actually a little confusing because documentation has already been updated but release is not out yet. I've spent last couple of hours figuring out why imports related to this feature are not working in my project only to realize that this feature is not available yet.

[andreaTP]

Hi @bachmanity1 , sorry for the confusion and trouble, fabric8 6.2.0 is out now and since we don't have it properly "versioned" I encourage you to browse the docs using the appropriate tag e.g.:
https://github.com/fabric8io/kubernetes-client/tree/v6.2.0/doc