Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow CRD generation of all detected CRs #399

Merged
merged 7 commits into from Sep 13, 2022
Merged

Conversation

metacosm
Copy link
Member

@metacosm metacosm commented Sep 8, 2022

  • feat: add HasMetadataUtils to extract metadata from ClassInfo instances
  • feat: expose associated resource information via LoadableResourceHolder
  • feat: decouple CRD generation from reconciler handling

@metacosm metacosm self-assigned this Sep 8, 2022
@derlin
Copy link

derlin commented Sep 9, 2022

Try locally on an existing project (cloned your branch, ran mvn install -DskipTests and imported the quarkus-operator-sdk at version 4.0.1-SNAPSHOT), I get:

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:2.11.2.Final:build (default) on project XXX: Failed to build quarkus application: java.lang.RuntimeException: Failed to load steps from class io.quarkiverse.operatorsdk.deployment.OperatorSDKProcessor: io/quarkiverse/operatorsdk/common/ResourceTargetingAugmentedClassInfo: io.quarkiverse.operatorsdk.common.ResourceTargetingAugmentedClassInfo -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal io.quarkus:quarkus-maven-plugin:2.11.2.Final:build (default) on project XXX: Failed to build quarkus application

Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to build quarkus application
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Failed to load steps from class io.quarkiverse.operatorsdk.deployment.OperatorSDKProcessor
Caused by: java.lang.RuntimeException: Failed to load steps from class io.quarkiverse.operatorsdk.deployment.OperatorSDKProcessor
Caused by: java.lang.NoClassDefFoundError: io/quarkiverse/operatorsdk/common/ResourceTargetingAugmentedClassInfo
Caused by: java.lang.ClassNotFoundException: io.quarkiverse.operatorsdk.common.ResourceTargetingAugmentedClassInfo

@metacosm
Copy link
Member Author

metacosm commented Sep 9, 2022

Try locally on an existing project (cloned your branch, ran mvn install -DskipTests and imported the quarkus-operator-sdk at version 4.0.1-SNAPSHOT), I get:

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:2.11.2.Final:build (default) on project XXX: Failed to build quarkus application: java.lang.RuntimeException: Failed to load steps from class io.quarkiverse.operatorsdk.deployment.OperatorSDKProcessor: io/quarkiverse/operatorsdk/common/ResourceTargetingAugmentedClassInfo: io.quarkiverse.operatorsdk.common.ResourceTargetingAugmentedClassInfo -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal io.quarkus:quarkus-maven-plugin:2.11.2.Final:build (default) on project XXX: Failed to build quarkus application

Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to build quarkus application
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Failed to load steps from class io.quarkiverse.operatorsdk.deployment.OperatorSDKProcessor
Caused by: java.lang.RuntimeException: Failed to load steps from class io.quarkiverse.operatorsdk.deployment.OperatorSDKProcessor
Caused by: java.lang.NoClassDefFoundError: io/quarkiverse/operatorsdk/common/ResourceTargetingAugmentedClassInfo
Caused by: java.lang.ClassNotFoundException: io.quarkiverse.operatorsdk.common.ResourceTargetingAugmentedClassInfo

You probably need to run mvn clean as well, first.

@derlin
Copy link

derlin commented Sep 9, 2022

You probably need to run mvn clean as well, first.

I just cloned the sdk project (so it is clean) and did the make clean on my project XXX first. Just retried to be sure. Same error.

@metacosm
Copy link
Member Author

metacosm commented Sep 9, 2022

You probably need to run mvn clean as well, first.

I just cloned the sdk project (so it is clean) and did the make clean on my project XXX first. Just retried to be sure. Same error.

Hmm, that is weird.

@metacosm
Copy link
Member Author

metacosm commented Sep 9, 2022

Will look into it, currently trying to figure out why the tests are failing…

@metacosm
Copy link
Member Author

Can you check again, @derlin, please? I've tried on a local project with the latest version of this branch and I didn't encounter any issue…

@derlin
Copy link

derlin commented Sep 10, 2022

Sure, I will try first thing on Monday

@derlin
Copy link

derlin commented Sep 12, 2022

@metacosm It works :)

@metacosm metacosm marked this pull request as ready for review September 13, 2022 10:46
@metacosm metacosm merged commit e9d1569 into main Sep 13, 2022
@metacosm metacosm deleted the generate-all-crds branch September 13, 2022 11:02
metacosm added a commit that referenced this pull request Sep 16, 2022
metacosm added a commit that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants