Fix the SchemaPropsOptions POJO, which getRequired() getter returns the wrong field value

[fabiobrz]

Description

This PR fixes the AbstractJsonSchema.SchemaPropsOptions.getRequired() method in order to return the required field value, rather than the nullable one.

Fixes #4394

FYI @andreaTP, @manusa

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• N/A - I have implemented unit tests to cover my changes
• N/A - I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[andreaTP]

Thanks @fabiobrz !

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[andreaTP]

Looking at it again, and wondering how can I have missed this in the tests ... I'm pretty sure this is covered ...

[fabiobrz]

Looking at it again, and wondering how can I have missed this in the tests ... I'm pretty sure this is covered ...

Hi @andreaTP - I thought about a simple unit test involving just the POJO itself, but then I thought that such principle should be extended to any bare POJOs that we use as property bags. Which definitely doesn't seem so good in terms of ROI.

I am doing some similar changes for java-gen, though, and will most likely make a better idea about the topic. BTW, feel free to assign #4384 to me, in case you wish and have the permissions to do so.

[andreaTP]

Assigned, thanks for volunteering!