Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't resolve filtered files #428

Merged
merged 3 commits into from Oct 3, 2022
Merged

fix: don't resolve filtered files #428

merged 3 commits into from Oct 3, 2022
+30 −26

Commits on Oct 3, 2022

  1. fix: don't resolve filtered files 

    - if they're `exclude`d / not `include`d, then we shouldn't be processing them
  - we're already not transforming them, so this just applies the same exclusion to resolving
  - this is _partly_ a regression from b0e3922, as that removed the `allImportedFiles` Set that previously filtered out files not in the `tsconfig` `include`
    - but that _itself_ was a regression that was removed -- files that didn't pass `filter` should have _never_ been resolved
      - basically, the `allImportedFiles` regression was covering up this long-standing bug

- also move `.d.ts` check to above the `filter` check
  - we shouldn't be adding declarations to the `cache`, in particular as we don't process declarations, so they'll never be marked as dirty
  - having this check above the `filter` should be slighltly more efficient as well (as would not having these files in the cache graph)

types: be more specific with `filter`'s type
- no need for this to be `any`
    @agilgur5
    agilgur5 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    bc1f73b View commit details
    Browse the repository at this point in the history

  2. build 

    - patch release has been waiting for a few weeks
    @agilgur5
    agilgur5 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1f3de90 View commit details
    Browse the repository at this point in the history

  3. pub: release v0.34.1 

    - patch bump with the past few fixes

- bump internal rpt2 version to 0.34.0
    @agilgur5
    agilgur5 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c306a08 View commit details
    Browse the repository at this point in the history