Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Early return after
filter
in theresolveId
hook, same as we do intransform
package.json
browser
field has no effect (bundling Axios) #427Details
if they're
exclude
d / notinclude
d, then we shouldn't be processing themallImportedFiles
Set
that previously filtered out files not in thetsconfig
include
filter
should have never been resolvedallImportedFiles
regression was covering up this long-standing bugalso move
.d.ts
check to above thefilter
checkcache
, in particular as we don't process declarations, so they'll never be marked as dirtyfilter
should be slightly more efficient as well (as would not having these files in the cache graph)types: be more specific with
filter
's typeany
Review Notes
I also did a
build
and version bump in this PR as folks have been waiting for a patch for a few weeks, c.f. #422 (comment) (I also recommended a patch in that PR's opening comment)